Size and SizeF should not throw on NaN
#22890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2024
mattleibow
changed the title
Size and SizeF should not throw on NaN
|
/rebase |
github-actions
bot
force-pushed
the
dev/size-nan
branch
from
87f2ff3 to
3f4d365
Compare
jsuarezruiz
reviewed
Jun 10, 2024
| throw new ArgumentException("NaN is not a valid value for size"); | ||
| _width = size; | ||
| _height = size; | ||
| Width = size; |
There was a problem hiding this comment.
Could we include some unit tests accepting NaN values to cover any unexpected change/behavior in the future?
|
Related PR #18971 |
PureWeen
approved these changes
Jun 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The other primitives are fine with
NaN:PointPointFRectRectFIn fact,
Rect.Sizemay throw because theRecthandlesNaNbut theSizeinstance does not.Issues Fixed
Fixes #16571
Possible alternative:
NaNs inRect'sWidthandHeightproperties #18971